Hey, what's wrong with Shadow the Hedgehog? Okay, the game was... a mess to put it lightly, but I think his introduction in Adventure 2 wasn't half bad. Despite his "edginess," there is an endearing quality to him that mainly cones in the way he plays off other characters, specifically Rouge in adventure 2 and Rouge and Omega in Sonic Heroes.
And on the other side of it, Shadow's misguided edgy writing really only shows up in 1 game, the one that shares his name. Every other title he's in, in my opinion, plays his character straight but tonenally consistent with what ever title he's in. Despite Sonic '06's many, many flaws, he genuinely comes off as cool in that title.
Consider reevaluating how you interpret some media. I know you're capable of deeper thinking when it comes to some content like ATLA but beyond that property, you tend to take surface level observations at face value. There plenty of missteps in the writing of several Sonic the Hedgehog games, but theyaee arguably more bright spots that are worth looking into.